Add: Reset button to global styles sidebar #25426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +243 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Sep 24, 2020
packages/edit-site/src/components/editor/global-styles-provider.js
Outdated
Show resolved
Hide resolved
oandregal
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Code-wise this is ready, although I'll defer to Noah for design input.
The only bit of feedback I have around IxD is:
- Can the reset button be disabled when there's no user changes (so it follows the same pattern than undo/redo)?
- "Reset all" is a bit confusing to me. Perhaps there's better alternatives along the lines of "Reset to defaults" or "Reset to theme"?
jorgefilipecosta
force-pushed
the
add/reset-button-to-the-global-styles-sidebar
branch
from
6ce2329
to
bb57785
Compare
jorgefilipecosta
force-pushed
the
add/reset-button-to-the-global-styles-sidebar
branch
from
bb57785
to
c00d25b
Compare
jorgefilipecosta
deleted the
add/reset-button-to-the-global-styles-sidebar
branch
|
Hi @nosolosw, your feedback was addressed. @noahshrader in case there are some design improvements that should be done just let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a reset all button on the global styles sidebar.
Fixes: #20868
How has this been tested?
I did some changes on the global styles sidebar and I verified that by pressing the global styles reset button I could reset all the changes.
Screenshots