Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Publish sidebar Cancel button not usable through speech recognit… #25441

Merged
merged 2 commits into from Sep 21, 2020
Merged

Fix 'Publish sidebar Cancel button not usable through speech recognit… #25441

merged 2 commits into from Sep 21, 2020

Conversation

prashanttholia
Copy link
Contributor

@prashanttholia prashanttholia commented Sep 18, 2020

…ion software' issue

Related Issue: #25194

Description

Fixes the issue of publisher sidebar cancel button not being usable through speech recognition software.

How has this been tested?

Tested using Speech Recognition Anywhere extension on Chrome browser on Windows machine.

Types of changes

Bug fix: Fixes the issue of publisher sidebar cancel button not being usable through speech recognition software.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@prashanttholia
Copy link
Contributor Author

Hey, apologies for the check failures. I shall fix them.

@prashanttholia
Copy link
Contributor Author

@afercia @allilevine, I have raised this PR related to the issue #25194.

As mentioned in the PR post above, I have only been able to test it using 'Speech Recognition Anywhere' extension on Chrome browser on Windows machine. I request you to let me know about a suitable free software that could be used to test the feature.

Also, I'm not sure whether this fix also required any changes in the React Native files. I also request you to let me know about the same.

Thanks.

@allilevine
Copy link
Contributor

👍 I tested with Voice Control and Safari (following the steps in #25194) and saying "Click cancel" closed the Publish panel.

@ZebulanStanphill ZebulanStanphill added [a11y] Labelling [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended labels Sep 18, 2020
Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@afercia
Copy link
Contributor

afercia commented Sep 21, 2020

@prashanttholia thanks for working on this!

To answer your question, I'm not sure there are good speech recognition software for Windows that are free. Traditionally, the most used one is Dragon but it's commercial software and pretty expensive.

On Windows 10, there's the built-in "Windows Speech Recognition" tool which can be used for testing, to some extent. Also to consider that different tools often give different results. For example, when testing with Voice Control on macOS and then with Windows Speech Recognition on Windows, I often get different behaviors.

The PR looks good to me, the change is simple, and everything is green. Merging!

@afercia afercia merged commit 5a3364f into WordPress:master Sep 21, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 21, 2020
@github-actions
Copy link

Congratulations on your first merged pull request, @prashanttholia! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@prashanttholia
Copy link
Contributor Author

Thanks @afercia!

I did try testing "Windows Speech Recognition", but it somehow did not work on my machine.

I am glad that the PR is being merged. Thanks to you and @allilevine for providing the opportunity to contribute!

@prashanttholia prashanttholia deleted the fix/publish-sidebar-cancel-button-not-usable-through-speech-recognition-software branch September 21, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants