Editor: Fix resetting the drop-zone states after dropping a file #2604
Conversation
youknowriad
added
the
[Type] Bug
components/drop-zone/provider.js
Outdated
| @@ -68,7 +68,7 @@ class DropZoneProvider extends Component { | |||
| } ); | |||
|
|
|||
| this.dropzones.forEach( ( { updateState } ) => { | |||
| updateState( { isDraggingOverDocument, isDraggingOverElement: false, position: null } ); | |||
| updateState( { isDraggingOverDocument: false, isDraggingOverElement: false, position: null } ); | |||
There was a problem hiding this comment.
Should consider splitting long line across multiple.
There was a problem hiding this comment.
we definitely need prettier 
one hour dev time gained per day :)
There was a problem hiding this comment.
object-curly-newline has options for configuring number of properties before newlines are required, and includes a fixer!
There was a problem hiding this comment.
Do you use the auto-fixer on IDE save? I never saw ESlint used for this, but yeah could be a good alternative for now 👍.
I'm using prettier "auto-save format" in other projects and it's really a huge gain.
There was a problem hiding this comment.
I don't personally, but a cursory search reveals this one for Sublime Text:
There was a problem hiding this comment.
I found a similar config in VS Core, I'll be trying it for some days. I'm not adding the rule right now, but we should consider it in a separate PR.
youknowriad
force-pushed
the
fix/reset-drop-zones
branch
from
7dfefb6
to
a02ef13
Compare
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
+ Coverage 31.38% 31.71% +0.32%
==========================================
Files 177 177
Lines 5413 5811 +398
Branches 949 1065 +116
==========================================
+ Hits 1699 1843 +144
- Misses 3139 3309 +170
- Partials 575 659 +84
Continue to review full report at Codecov.
|
closes #2597
The dropzone classes were not being cleaned on drop which causes the dropzone to appear over the controls.
Testings instructions