Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links: Add Patreon, Telegram, and Tiktok icons #26118

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 14, 2020

Description

Adds three new social icons to the Social Links block

How has this been tested?

  • Confirm the icons can be added within social links block
  • Confirm the colors look correct for the different style variants

Screenshots

image

Types of changes

  • Adds new SVG files for the icons
  • Adds new variants for the icons
  • Adds new CSS rules for the icons
  • Adds PHP for server-side rendering of the icons

@mkaz mkaz force-pushed the add/tiktok-telegram-patreon branch from b70fad3 to 4c4644a Compare October 14, 2020 17:38
@mkaz mkaz added [Block] Social Affects the Social Block - used to display Social Media accounts Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Oct 14, 2020
@github-actions
Copy link

github-actions bot commented Oct 14, 2020

Size Change: +1.65 kB (0%)

Total Size: 1.19 MB

Filename Size Change
build/annotations/index.js 3.54 kB -1 B
build/block-directory/index.js 8.6 kB -1 B
build/block-editor/index.js 130 kB -1 B
build/block-library/index.js 144 kB +1.24 kB (0%)
build/block-library/style-rtl.css 7.76 kB +57 B (0%)
build/block-library/style.css 7.76 kB +56 B (0%)
build/blocks/index.js 47.6 kB +2 B (0%)
build/components/index.js 169 kB +234 B (0%)
build/components/style-rtl.css 15.4 kB -63 B (0%)
build/components/style.css 15.4 kB -61 B (0%)
build/data/index.js 8.63 kB +2 B (0%)
build/edit-navigation/index.js 10.6 kB -4 B (0%)
build/edit-post/index.js 306 kB +3 B (0%)
build/edit-site/index.js 21.1 kB +187 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/style-rtl.css 6.3 kB 0 B
build/edit-post/style.css 6.29 kB 0 B
build/edit-site/style-rtl.css 3.77 kB 0 B
build/edit-site/style.css 3.77 kB 0 B
build/edit-widgets/index.js 21.3 kB 0 B
build/edit-widgets/style-rtl.css 2.97 kB 0 B
build/edit-widgets/style.css 2.97 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.5 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.04 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.07 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@kirilzh
Copy link
Contributor

kirilzh commented Oct 20, 2020

Looks good to me

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkaz everything looks good 🎉 , confirmed on mobile platform.

Screenshot 2020-10-20 at 12 09 37

@mkaz mkaz merged commit ebff8b5 into master Oct 20, 2020
@mkaz mkaz deleted the add/tiktok-telegram-patreon branch October 20, 2020 13:31
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code
Projects
None yet
4 participants