Minor iterations to grouping for preferences panel #26198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This responds to feedback on #25837 and iterates the grouping.
|
Size Change: +1 B Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
Thanks, @shaunandrews. I am going to merge this as iterations can happen, but I think let's get this in for now and take from there. Iterations are always possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This responds to feedback on #25837 and iterates the grouping of the changes to the preferences panel. There have been quite a few changes for this release, but the grouping wasn't really modified. This small PR responds to the feedback by @mtias to adjust the grouping.
The iterations included in this are:
This doesn't respond to the suggestion of iteration the keyboard section. What that section could or couldn't become feels like a more in-depth discussion. For example, it could flourish into an accessibility section such as Slack, Apple and many other applications. However, that feels like it needs more time than a few days before a release, so perhaps another issue should have that discussion. If that's a wrong assessment, I am very happy to work up an iteration on that based on feedback.
I would love general feedback on this and really like a code review. Ideally, this would slide in under the wire for the release, but I understand if that is too late now to do so. I am labelling and cc'ing in @tellthemachines just incase for things like test passing.