Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable: Fix Placeholder styling #2626

Merged
merged 1 commit into from Sep 4, 2017

Conversation

youknowriad
Copy link
Contributor

On an empty paragraph block with a background color, a padding was applied using an extra className. But these extra classNames were not applied to the placeholder, which caused the placeholder to be incorrectly styled.

Testing instructions

  • Create a paragraph block
  • Apply a background color
  • Unselect the block
  • The placeholder should be shown properly.

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 31, 2017
@youknowriad youknowriad self-assigned this Aug 31, 2017
@youknowriad youknowriad added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Aug 31, 2017
@youknowriad youknowriad merged commit de53baf into master Sep 4, 2017
@youknowriad youknowriad deleted the fix/paragraph-with-background-placeholder branch September 4, 2017 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants