E2E Tests: Fix demo test by disabling the welcome dialog #26314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
gziolo
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
gziolo
commented
Oct 20, 2020
|
I can confirm it fixes the demo test. Let's move forward and follow-up if something went wrong. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #25659 where I noticed that the demo e2e test fails from time to time. The issue seemed to be the Welcome Dialog which prevents all the interactions to happen in the first place.
The proposed solution is to open a new editor page to remove the popup and properly configure full-screen mode before proceeding with the actual test. The issue happens mostly because all other tests depend on
createNewPagehelper's behavior.I also decided to combine two tests into one given that the first one always passes and the second is not reliable. It seems like merging both resolves the issue. There is an open issue about this bug:
dequelabs/axe-core-npm#98
It seems like there is some iframe injected that triggers the issue.
How has this been tested?