New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for line height at the global level #26767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
November 6, 2020 10:52
oandregal
added
the
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
label
Nov 6, 2020
oandregal
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
November 6, 2020 10:53
oandregal
force-pushed
the
update/enable-line-height-global
branch
from
November 6, 2020 10:55
7cabc22
to
82a7a87
Compare
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
aristath
approved these changes
Nov 6, 2020
Failing tests don't seem to be related to this PR so it looks to me like this is OK to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the line-height property at the global level. See WordPress/theme-experiments#76