Visual editor: remove 4 wrapper divs #27035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Nov 17, 2020
| useBlockSelectionClearer( ref ); | ||
| useTypewriter( ref ); | ||
| useClipboardHandler( ref ); | ||
| useTypingObserver( ref ); |
There was a problem hiding this comment.
These 5 lines are the key. Behaviour can be added with hooks that have access to the same wrapper ref. In the future, this could be the body of an iframe.
|
Size Change: +67 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
ellatrix
force-pushed
the
try/collapse-nested-divs
branch
from
967abdb
to
813fbea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs removes 4 wrapper divs and one empty div from the visual editor. These divs were used to bind events, which can also be done with access to the ref alone.
Another div was removed in #26994 from the root container earlier.
Aside from simplifying things, this is also useful (though not strictly necessary) when we iframe the editor content. Ideally, the content of the iframe is purely the content without any wrapper divs. Again, this is not strictly necessary, but it will make it easier to style content later on by third parties.
How has this been tested?
Screenshots
Types of changes
Checklist: