Enable Post Featured Image to be set, unset and replaced #27224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Full Site Editing
[Type] Feature
|
Size Change: +294 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Nov 24, 2020
aristath
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Code looks good and appears to be working fine on my test 👍
I agree that it does look weird to have a group for a single item as mentioned in the other comment by @gziolo but it doesn't interfere with anything so I'm OK with this.
gziolo
approved these changes
Nov 24, 2020
gziolo
reviewed
Nov 24, 2020
| > | ||
| { __( 'Clear' ) } | ||
| </ToolbarButton> | ||
| <MediaReplaceFlow |
There was a problem hiding this comment.
One thing I noticed is that MediaReplaceFlow uses ToolbarGroup internally:
That puts a group in another group. It something that we should look into separately as it might be too restrictive choice as @jasmussen pointed out in the linked issue.
|
I'm unclear about the "unset" feature on this block. Would a user ever unset the featured image and leave the block blank? Unsetting, to me, feels much more like just removing the block. Otherwise the user would "replace" the image. Also now that I see this in action, the unset icon needs iterating. It doesn't work visually next to the block icon. |
|
Here's a visual how the flows currently work in relation to this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #24813
This PR enables
Post Featured Imageblock to add a Featured image if not exists, to unset it and replace it. If no Featured image exists it shows a Placeholder to set one.Screenshots
Checklist:
-- Thank you @mapk for creating the icon so fast after asking :)!