[Table Block] Add border-collapse to default block styles #27628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2020
|
I am no longer able to run npm build on the PR itself as it is not synced with the master branch, but I have tested the changes and they work correctly (We may need to update some default themes to remove duplicate styles afterwards). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the border-collapse style attribute to the default table block styles, fixing two issues:
A mismatch between front-end and editor default table block styles.
The attribute is incorrectly applied in the themes stylesheet — the user agent stylesheet overrides the inherited style from the theme stylesheet on the front-end: