Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to indicate why priority queue callbacks may be undefined #28337

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Add note to indicate why priority queue callbacks may be undefined #28337

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b3e1c0
Check that waitingList callbacks are defined before calling to preven…
Jan 20, 2021
af40466
switch to typeof as jest.fn does not seem to be an instance of Function
Jan 20, 2021
af38a18
Add debugging to try and track down reason for undefined callback
Feb 4, 2021
9c562dc
Remove debugging
Feb 9, 2021
99bc2ac
Instead of checking for undefined callback check that the element has…
Feb 10, 2021
54426a7
Switch to just adding a comment to highlight cause of issue
Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/priority-queue/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ export const createQueue = () => {
const callback = /** @type {WPPriorityQueueCallback} */ ( elementsMap.get(
nextElement
) );
// If errors with undefined callbacks are encountered double check that all of your useSelect calls
// have all dependecies set correctly in second parameter. Missing dependencies can cause unexpected
// loops and race conditions in the queue.
callback();
elementsMap.delete( nextElement );
} while ( hasTimeRemaining() );
Expand Down