Site Editor: Fix gray screen on refresh when editing pages and posts #28413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
vindl,
Copons,
jeyip and
Addison-Stavlo
6 tasks
ntsekouras
reviewed
Jan 22, 2021
| @@ -135,7 +135,11 @@ export function setHomeTemplateId( homeTemplateId ) { | |||
| */ | |||
| export function* setPage( page ) { | |||
| if ( ! page.path && page.context?.postId ) { | |||
| page.path = `?p=${ page.context.postId }`; | |||
| if ( page.context?.postType === 'page' ) { | |||
There was a problem hiding this comment.
The problem lies to the fact that previous path didn't start with the /.
page.path = `/?p=${ page.context.postId }`
should be fine.
There was a problem hiding this comment.
That will not always work, as WP can be installed in the subdirectory of a server, like example.com/wordpress-installed-here/.
We would therefore need to qualify the URL against the home URL of the site, which it looks like can be had with select( 'core' ).getSite().url.
mattwiebe
requested changes
Jan 22, 2021
There was a problem hiding this comment.
I appreciate the quick turnaround on this. With this comment addressed, I think this should be good to go.
And while I don't consider this a blocker, I do not really love how a request to ?page_id=n will result in a 301 redirect on the majority of sites with pretty permalinks enabled. This is part of what I was trying to avoid in #28407, although I failed to mention it (added a comment there)
|
@mattwiebe Thanks for the review! I just pushed a commit which implements an alternative solution. Instead of constructing URL, we fetch the entity record and use the
I'll do some testing in a subdirectory and see what happens. EDIT: Just realized we are returning the whole path. So it works fine in a subdirectory. (Also tested and can confirm it's working) |
|
Size Change: -21.3 kB (-2%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28315
Description
setPageaction issued wrong requests when passingpostTypeandpostIdonly (no path specified). Let's use the right URL based on thepostType.Note:
pathshould be absolute here to avoid issuing requests toadmin.php.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: