[Inserter]: Add keyboard navigation in Patterns #28520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Inserter
|
Size Change: +6.57 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ntsekouras
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
diegohaz
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Thanks @ntsekouras! I made a suggestion, but the code looks good overall. I wonder if we need design feedback for the layout change?
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
|
yeah, can't we retain the two columns layout for the search results? |
|
Thanks for reviewing @diegohaz and @youknowriad 👍 - I reverted the styles and addressed the feedback. I've also added the |
ntsekouras
removed
the
Needs Accessibility Feedback
mcsf
approved these changes
Feb 10, 2021
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #28245
This PR adds keyboard navigation to the
Patterns Listin inserter. It uses theCompositecomponent fromReakit, which is also used for block types list.Testing instructions
Patterns.