Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Component: Increase color and padding specificity #28619

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Navigation Component: Increase color and padding specificity #28619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3afde1
Increase color and padding specificity
psealock Feb 1, 2021
27c1e76
add storybook case
psealock Feb 1, 2021
6d492e0
add the padding back to ItemUI
psealock Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/components/src/navigation/stories/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ export function DefaultStory() {
onClick={ () => setActiveItem( 'item-2' ) }
title="Item 2"
/>
<NavigationItem>
<a
className="components-button"
href="http://www.example.com"
>
External Link
</a>
Copons marked this conversation as resolved.
Show resolved Hide resolved
</NavigationItem>
<NavigationItem
item="item-sub-menu"
navigateToMenu="sub-menu"
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/navigation/styles/navigation-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,11 @@ export const ItemBaseUI = styled.li`
margin-bottom: 0;

button,
a.components-button,
a {
width: 100%;
color: ${ G2.lightGray.ui };
padding: ${ space( 0.75 ) } ${ space( 2 ) };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this here would leave simple text items (isText) without appropriate padding.

See Navigation > More Examples in the Storybook:

Screenshot 2021-02-15 at 13 32 57

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this here would leave simple text items (isText) without appropriate padding.

Good find, thank you. I added this padding back to the ItemUI


&:hover,
&:focus:not( [aria-disabled='true'] ):active,
Expand Down