block-editor package: Replace hardcoded store name strings #28775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Code Quality
david-szabo97
requested review from
cameronvoell,
ellatrix and
guarani
as code owners
17 tasks
|
Size Change: -657 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
david-szabo97
added
the
[Status] In Progress
|
Having problems with native files 🤔 I'll give it another go, if I can't get it to work then I'll leave out native files from this PR and leave it to someone else who is experienced with the mobile part. |
|
Couldn't replace No idea why it's happening and how to fix it 😬 We can merge it as is and replace them in a follow-up PR to keep the changes separate. |
david-szabo97
removed
the
[Status] In Progress
gziolo
reviewed
Feb 8, 2021
| @@ -22,7 +22,7 @@ import { | |||
| import * as selectors from '../selectors'; | |||
| import reducer from '../reducer'; | |||
| import * as actions from '../actions'; | |||
| import '../..'; | |||
| import { STORE_NAME as blockEditorStoreName } from '../../store/constants'; | |||
There was a problem hiding this comment.
It should be enough to use:
Suggested change
| import { STORE_NAME as blockEditorStoreName } from '../../store/constants'; | |
| import { STORE_NAME as blockEditorStoreName } from '../constants'; |
There still might be some cyclic dependencies in the React Native code, so it's better to leave everything like that for the final iteration. I scanned all the changes and everything looks good. I might miss something because it's a type of change that machines are better to process. Anyway, let's proceed. Thank you for working on this, awesome job! |
gziolo
approved these changes
Feb 8, 2021
gziolo
deleted the
update/block-editor-package-replace-hardcoded-strings
branch
fullofcaffeine
pushed a commit
to Automattic/wp-calypso
that referenced
this pull request
Feb 19, 2021
Since WordPress/gutenberg#28775 namespace is not always a string.
fullofcaffeine
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Feb 19, 2021
Since WordPress/gutenberg#28775 namespace is not always a string. Co-authored-by: Bart <bartlomiej.kalisz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #27088
Replace hardcoded store names with their store object.
How has this been tested?
Make sure tests are passing. Smoke test.
Types of changes
Code Quality
Checklist: