RangeControl: Fix input / slider widths #28816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
|
Merging this hot fix up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the UI regression for RangeControl from the latest Flex component update. The patch solution was to force the specific widths/margins for the inner
input.The longer term solution would be to refactor how layout rendering for
RangeControlto use the newHStackcomponents fromcomponents/ui/hstack.Screenshots
Before
After
How has this been tested?
Tested in local Gutenberg
npm run devChecklist: