New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Update color-picker snapshot tests to use diff matching #28925
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 from me!
display: inline-block; | ||
margin-bottom: 8px; | ||
} | ||
"Snapshot Diff: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to change those hints in the output? I'm nitpicking in general, but it would better explain the intent if there was something like:
"Snapshot Diff:
- Base component
- Current component
It's a really nice improvement. 43% less of the output to process 😄 |
Description
This PR updates the
color-picker
component's snapshot tests to use diff matching. This reduces the size of the snapshot tests to just what is changing. See #28897 for more details on how this works and why it's desirable.How has this been tested?
Unit tests pass. No changes to actual code, just unit tests.
Types of changes
Non-breaking changes
Checklist: