Convert navigation link to use hooks and context. #28996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
talldan,
retrofox,
kevin940726 and
grzim
tellthemachines
added
[Block] Navigation
|
Size Change: -116 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Feb 15, 2021
| selectedBlockId, | ||
| ] )?.length, | ||
| numberOfDescendants: descendants, | ||
| isBeingDragged: isDraggingBlocks(), |
There was a problem hiding this comment.
I think this is mostly used to handle when other blocks are being dragged, so the name change isn't quite right.
There was a problem hiding this comment.
I couldn't reuse isDraggingBlocks without making linter unhappy, and I'm not sure what the best name might be. Is areBlocksBeingDragged too verbose?
There was a problem hiding this comment.
It's never nice, but the two options are usually assigning the selectors to a variable first and accessing through that:
const selectors = select( blockEditorStore );
// ...
isDraggingBlocks: selectors.isDraggingBlocks(),Or prefixing the function with an underscore:
const {
isDraggingBlocks: _isDraggingBlocks,
} = select( blockEditorStore );
return {
isDraggingBlocks: _isDraggingBlocks(),
}There was a problem hiding this comment.
😑 we can live with the underscore, I guess.
tellthemachines
force-pushed
the
fix/nav-link-cleanup
branch
from
359eb5b
to
6eb17c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on this comment.
The Navigation link block edit function was using a messy mix of HOCs and hooks for select/dispatch functionality. This PR cleans up and converts it to use only hooks, and get the inherited styles from the parent Navigation block from context instead of attributes.
How has this been tested?
Tested in browser by adding a Navigation block, some links and some submenus with more links, and checking all is working correctly.
Screenshots
Types of changes
Checklist: