New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dom-ready: Safe access to document #29068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of curious to use domReady in a a node context though . There's "dom" in the name :) |
Size Change: +5 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Great question 😉 The problem is that |
Makes sense. |
Description
This PR changes the
dom-ready
package to safely accessdocument
. This is helpful for the instances where thedomReady
utility is used in a Node context.Related to #29038.
How has this been tested?
Types of changes
This is an enhancement, aiming at providing better SSR support for the
dom-ready
package.Checklist: