Extend updateBlockAttributes to provide for different attribute changes for each block in the clientIds array #29099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for each block in the clientIds array
glendaviesnz
added
the
[Status] In Progress
glendaviesnz
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
6 tasks
|
Size Change: +2.44 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
gziolo
added
[Feature] Blocks
youknowriad
reviewed
Feb 18, 2021
| @@ -822,7 +822,9 @@ export const blocks = flow( | |||
| ( accumulator, id ) => ( { | |||
| ...accumulator, | |||
| [ id ]: reduce( | |||
| action.attributes, | |||
| action.attributes[ id ] | |||
There was a problem hiding this comment.
It seems a bit weird to rely on the "id" for this check. What if there's an attribute that conflicts with the "id" (both are strings). I wonder if it's better to be explicit here and have a separate action (or a flag).
cc @ellatrix
There was a problem hiding this comment.
@youknowriad I guess I was thinking that there was no chance of an attribute name being in the format of "b4c1d31e-fba3-4438-8d87-8d3554d8c4fb" and randomly matching an actual block clientId.
I think you are right though, the API is better if we are more explicit. It seems like the two options are too close to warrant a whole separate action so have added a uniqueByBlock flag. Let me know if you think this is a suitable way forward and I will extend the unit tests.
26 tasks
youknowriad
approved these changes
Feb 22, 2021
glendaviesnz
removed
the
[Status] In Progress
glendaviesnz
changed the title
added 2 commits
February 23, 2021 09:27
glendaviesnz
deleted the
update/update-block-attributes-for-attributes-per-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the gallery refactor PR we are looking for a way to
undoall changes to child image attributes in one go. UsingupdateBlockAttributesallows this, but currently all the blocks passed to it must have the same attributes. The gallery changes required that each child block update has slightly different attributes, eg. the unique media file url.The PR extends
updateBlockAttributesto allow the attributes param to alternatively have attributes keyed by clientId.How has this been tested?
Currently just manually tested against some changes in gallery PR. Will add unit tests if this approach is approved.