Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show page titles special characters in the parent page selector #29104

Merged
merged 3 commits into from Feb 23, 2021
Merged

Show page titles special characters in the parent page selector #29104

merged 3 commits into from Feb 23, 2021

Conversation

Quintis1212
Copy link
Contributor

Hello everyone ) This is patch for correct right apostrophe display from ticket https://core.trac.wordpress.org/ticket/52415 from my branch of gutenberg

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 18, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Quintis1212! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Quintis1212 Quintis1212 changed the title Updated branch #52415 ticket Feb 18, 2021
youknowriad
youknowriad approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit 3a794c4 into WordPress:master Feb 23, 2021
@youknowriad youknowriad changed the title #52415 ticket Show page titles special characters in the parent page selector Feb 23, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @Quintis1212! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 10.1 milestone Feb 23, 2021
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Quintis1212 @youknowriad