Better sorting algorithm while searching parent pages #29143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +681 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Feb 19, 2021
|
@youknowriad didn't get a chance to test this; overall seemed fine. Thanks for the improvement. Thinking we should add a similar toggle to author selector here so that if the site has a small number of pages, we use a traditional HTML selector vs the searchable selector. |
|
@adamsilverstein make sense, we might even consider making that behavior built-in with a boolean/threshold prop in ComboboxControl maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the search algorithm for parent pages by adding some client logic to: