Fix white screen on RTL languages #29256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
force-pushed
the
fix/gb-10-css-error
branch
from
2be8bcf
to
119b6ce
Compare
|
Size Change: -99 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
🙏 |
The trick is to run it thrice so you know twice was enough 😏 |
ockham
added
the
[Priority] High
youknowriad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29248. Supersedes #29241.
The trick is to run
npm itwice 🤦♂️(After running it only once, it removes
create-emotionfrom the package lock, causing TS errors during the build.)Furthermore, we had to cherry-pick some
FlexGap/FlexItemDisplayrelated type fixes from #28568.How has this been tested?
See #29248
Types of changes
Bug fix