Fix: Invert gallery gravity. #29367
Merged
Fix: Invert gallery gravity. #29367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Block] Gallery
|
On a separate note, I recall working on this back in the day. Due to the use of flex, it was hard to get the gallery to work with IE11, and I hazily recall this bottom alignment being related to that. So it would be good to sanity check the gallery both before and after this change, in IE11. |
|
Size Change: +28 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
It might also be worth considering if people might be relying on this default already. |
ZebulanStanphill
added
[Type] Enhancement
|
@scruffian @MaggieCabrera @kjellr do would you have any insights in whether people might rely on the current behavior? Thank you for looking. |
|
As far as I know this change looks good. |
|
I'm cool with merging this PR, looks good 👍 |
|
Thank you for the review! Grid could potentially be a variation? |
Sure, it could be... Of course not related to this PR, just food for thought 😄 |
It's possible, but unlikely. The bottom-alignment always seemed like it was a bug to me. Glad to see this land. 🙌 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29316. Uncropped images fell to the floor. This PR let's them reach for the stars. They may not catch any, but they won't end up with a handful of mud either.
How has this been tested?
Insert a gallery with varying image sizes, then untoggle the crop feature.
Screenshots
Before:
After:
Checklist: