New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop some dead code from the Visual Editor Component #2937

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Oct 9, 2017

No description provided.

@youknowriad youknowriad self-assigned this Oct 9, 2017

@youknowriad youknowriad requested a review from iseulde Oct 9, 2017

@iseulde

iseulde approved these changes Oct 9, 2017

👍 Could you link the commit that removed this.onKeyDown? I'm surprised the linter did not error...

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Oct 9, 2017

Contributor

@iseulde I don't know which commit did this :P, Let me try to find it

Contributor

youknowriad commented Oct 9, 2017

@iseulde I don't know which commit did this :P, Let me try to find it

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Oct 9, 2017

Contributor

Got it, it was removed here #1944

Contributor

youknowriad commented Oct 9, 2017

Got it, it was removed here #1944

@youknowriad youknowriad merged commit b1eda06 into master Oct 9, 2017

3 checks passed

codecov/project 33.94% (+0.01%) compared to aec63ef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the drop/dead-code-visual-editor branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment