Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToC block: re-enable + use static markup and only support core Heading and Page Break blocks #29739

Merged
merged 25 commits into from
May 6, 2022
Merged

ToC block: re-enable + use static markup and only support core Heading and Page Break blocks #29739

merged 25 commits into from
May 6, 2022

Commits on May 5, 2022

  1. ToC block: use static markup and only support core Heading and Page B… 

    …reak blocks.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c53df83 View commit details
    Browse the repository at this point in the history

  2. Remove unused index prop from NestedHeadingData.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    afadefa View commit details
    Browse the repository at this point in the history

  3. Add unit test fixtures.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2796c70 View commit details
    Browse the repository at this point in the history

  4. Update test. 

    Because the ToC block has "Heading" in its description, it was changing the availableBlocks length to 2.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    f564667 View commit details
    Browse the repository at this point in the history

  5. Use some TypeScript.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4b7bbc6 View commit details
    Browse the repository at this point in the history

  6. Disable permalink support when core/editor store is unavailable.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    0ff623d View commit details
    Browse the repository at this point in the history

  7. Add Zebulan as code owner for Table of Contents.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8ba556a View commit details
    Browse the repository at this point in the history

  8. Switch from ul to ol for list element. 

    See https://stackoverflow.com/a/58733251.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    dc2730a View commit details
    Browse the repository at this point in the history

  9. Optimize re-renders caused by shallow comparisons of useSelect return… 

    … value.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8f7db2d View commit details
    Browse the repository at this point in the history

  10. Optimize calculating which page the block is on.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4282578 View commit details
    Browse the repository at this point in the history

  11. Enable Heading anchor auto-generation when a Table of Contents is in … 

    …same post.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    3080087 View commit details
    Browse the repository at this point in the history

  12. Add List -> Table of Contents block transform.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    803eddc View commit details
    Browse the repository at this point in the history

  13. Prevent links from being clicked in the editor since they don't work … 

    …there.

Heading blocks in the editor don't even use their "anchor" block attribute in the rendered HTML "id" attribute of their editor form.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6a724bf View commit details
    Browse the repository at this point in the history

  14. Strip HTML tags from listed headings.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    1eb8d22 View commit details
    Browse the repository at this point in the history

  15. Prefer <Disabled /> over pointer-events rule

    @mcsf @ZebulanStanphill
    mcsf authored and ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e7e866a View commit details
    Browse the repository at this point in the history

  16. Make comment formatting consistent.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6221796 View commit details
    Browse the repository at this point in the history

  17. Simplify TypeScript config.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    38bb612 View commit details
    Browse the repository at this point in the history

  18. Simplify condition using optional chaining in utils.ts. 

    Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
    @ZebulanStanphill @mcsf
    ZebulanStanphill and mcsf committed May 5, 2022
    Configuration menu
    Copy the full SHA
    a8a1cbd View commit details
    Browse the repository at this point in the history

  19. Fix page index calculation breaking when ToC or Page Break is nested. 

    Massive props to @mcsf for figuring this out.

Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
    @ZebulanStanphill @mcsf
    ZebulanStanphill and mcsf committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6d9c653 View commit details
    Browse the repository at this point in the history

  20. Make comment about editor store dependency consistent with other plac… 

    …es in the codebase.
    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    21adec5 View commit details
    Browse the repository at this point in the history

  21. Simplify logic thanks to changes made in #39985.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    fa6cc7d View commit details
    Browse the repository at this point in the history

  22. Optimize logic when onlyIncludeCurrentPage is false.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2ed8a4a View commit details
    Browse the repository at this point in the history

  23. Revise JSDoc for permalink const.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c439c5b View commit details
    Browse the repository at this point in the history

  24. Update inspector panel title as per #40275.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    425109f View commit details
    Browse the repository at this point in the history

  25. Make block experimental.

    @ZebulanStanphill
    ZebulanStanphill committed May 5, 2022
    Configuration menu
    Copy the full SHA
    327338f View commit details
    Browse the repository at this point in the history