-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Allow multiple words in the autocomplete phrase matcher #29939
Conversation
Size Change: +46 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
I think we should also add a simple e2e test that will prevent future regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a user point of view, this works GREAT! I can search easily, it works for a variety of use cases, and it's easy to "get out of searching" by clicking the space bar twice. Someone else will need to chime in around the technical approach :) Nice work.
2.word.mov
(new video without audio of me jamming to throw back music haha)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and it improves the user experience 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great
A follow-up ready in #29978. |
Description
A try to fix #29495.
The approach I explore works as follows:
My hope is that the review process and test coverage will confirm that this proposal is reasonable.
How has this been tested?
Add a Paragraph block and type
/social icons
and make sure it is able to select a block.Screenshots
Screen.Recording.2021-03-17.at.18.16.59.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: