Fix InputControl label alignment #30033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzim
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
7 tasks
kevin940726
reviewed
Mar 22, 2021
|
What is overriding the styles? Just adding specificity will cause problems when consumers of this component do need to override these styles for one reason or another. It looks like this is a fairly new bug (at least I remember this working correctly as recently as a couple months ago) so it seems like a regression that could be fixed rather than trying something like we're doing in this PR here. What do you think about trying to find the root cause of this issue instead given it used to work as expected? |
Expanding on @sarayourfriend 's comment. Why
|
|
Oh yes I remember this now @ItsJonQ didn't we see this in a different area as well? At the time we didn't need to fix it for some reason. Swapping out |
IMO, it shouldn't (not in the long term anyway). |
|
I don't want to leak too much of the conversation in #29689 here but yes, at least for now compounding specificity is going away. I'll open a PR to upgrade G2. |
|
@sarayourfriend Cool :). Thank you! |
|
Opened here #30146 |
|
Thank you all for your input:) |
|
@grzim (Phew!) Thanks for the update 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #30026
Solves the issue of broken label positioning in the
InputControlcomponent.The problem is with styles that are being overwritten - the proposition in the PR is to add higher priority to these styles with
&, so we can preserve the way everything is styled there (7&is the minimal number to apply styles).Another solution is to add styles directly applied to a component
which looks cleaner but it would introduce a different way of adding styles (everything is handled by styled-components now).
How has this been tested?
4
Screenshots
Types of changes
Bug fix
Checklist: