Mobile - Global styles: Block-specific styles #30997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/global-styles-root-styles
…ure/global-styles-root-styles
geriux
added
[Status] In Progress
|
Size Change: +12.2 kB (+1%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
4 tasks
geriux
changed the base branch from
rnmobile/feature/global-styles-root-styles
to
rnmobile/3163-GSS
…ents (#30684) * Mobile - Read global styles and set color palette and gradients * Parse all color variables * Fix gradients * Update global styles mocked data * Move color settings * Removed added spaces * Add tests * Update experimental features path and prepare for rawGlobalStylesBaseStyles * Remove mock data and update code to use latest API changes
# Conflicts: # packages/editor/src/components/provider/index.native.js
geriux
changed the title
|
Hey @ellatrix 👋 I was wondering if you have some time to give this PR a look, I tested the web editor and these changes don't affect the current functionality. It adds the Thank you! |
ellatrix
reviewed
Jul 6, 2021
| @@ -41,6 +41,7 @@ export default function ListEdit( { | |||
| setAttributes, | |||
| mergeBlocks, | |||
| onReplace, | |||
| mergedStyle, | |||
|
Ok, for web this seems fine. |
7 tasks
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Mobile - Read global styles and set color palette and gradients * Mobile - Enable colors for blocks that support it * Parse all color variables * Mobile - Set background, title, text and link colors * Fix gradients * Add placeholder color * Add support to block styles * Add reset button in color picker * Fix placeholder colors * Fix paddings and remove Columns placeholder solid background * Don't reset paddings for inner blocks that have paddings already * Mobile - Block styles support * Add fallback text color to blocks * Adds new Prop for Global Styles Settings * Rename updateTheme to be more generic for update settings include GSS (#31566) * Fix wrong naming of subscribeUpdateEditorSettings * Update Gutenberg demo * Updates new props to rawStyles and rawFeatures * Update iOS Bridge for new values * Mobile - Global styles: Pass settings and set color palette and gradients (#30684) * Mobile - Read global styles and set color palette and gradients * Parse all color variables * Fix gradients * Update global styles mocked data * Move color settings * Removed added spaces * Add tests * Update experimental features path and prepare for rawGlobalStylesBaseStyles * Remove mock data and update code to use latest API changes * Removes Android rawFeatures prop * Mobile - Remove usage of rawFeatures * Remove rawFeatures * Adds raw Styles in React Native Bridge * Mobile - Pass rawStyles on initial props and fix colors and gradients * Add Raw Features back * Revert "Removes Android rawFeatures prop" This reverts commit 32a2b3a. * Add rawFeatures in the mobile editor * Mobile - Global styles: Set theme's background and text color (#30810) * Mobile - Read global styles and set color palette and gradients * Mobile - Enable colors for blocks that support it * Parse all color variables * Mobile - Set background, title, text and link colors * Fix gradients * Add placeholder color * Update global styles mocked data * Move color settings * Removed added spaces * Add tests * Update experimental features path and prepare for rawGlobalStylesBaseStyles * Add missing provider * Get the right color attribute * Remove mock data * Mobile - Fix base global colors * Remove old usage of useEditorFeature * Remove old mock data * Add support for block styles of the Verse block in mobile * Rename mergedStyle to style Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: Chip <chip.snyder3@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2195
This PR is a continuation of #30684 and #30810
Description
This PR adds support to render the theme's block-specific styles. It also adds a reset option in the color picker.
How has this been tested?
Precondition
To be able to test this feature you need a WordPress 5.8 site running with the Gutenberg plugin and a FSE theme.
Now you should have all needed to test this PR.
In the WP Admin dashboard:
Group,Paragraph,Heading,List,Verse,Media&Text,Columns,Column,Buttons.On the mobile editor
Android[Global Styles] Adds Global Styles API Call and passes the value to the editor via a new prop wordpress-mobile/WordPress-Android#14597iOS[Global Styles] Implement Global Styles endpoint wordpress-mobile/WordPress-iOS#16411Reset custom color selection
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).