Scripts: Update puppeteer-core to the latest version
#31138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.49 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/puppeteer
branch
from
a75f4b5
to
18adc46
Compare
|
This new Jest reporter is incredibly helpful! Major props to @ockham 💯 🎉 |
This was referenced Apr 23, 2021
Merged
|
^ I have opened PR for the writing flow, RTL and undo tests that are failing. The only remaining one is the widgets one. |
ellatrix
force-pushed
the
update/puppeteer
branch
from
18adc46
to
6ae63c8
Compare
Nice, that was fast 💯
@kevin940726 or @talldan, can you investigate? |
gziolo
changed the title
puppeteer-core to the latest version
gziolo
added
[Package] Scripts
7 tasks
youknowriad
force-pushed
the
update/puppeteer
branch
from
9dad5a1
to
172b6ad
Compare
|
Rebased to take into consideration the "adding-widgets" fix. In theory, we should be good to go. |
gziolo
approved these changes
Apr 26, 2021
|
It's cool that this PR actually allowed us to find real bugs (writing flow, rtl) |
It's a recurring pattern with Puppeteer upgrades 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bundled
puppeteer-core(^5.5.0) dependency has been upgraded to version^9.0.0. Puppeteer uses Chromium v91 instead of Chromium v88. See the full list of breaking changes of 9.0.0 and lower versions.Testing
Run
npm run test-e2eand make sure all tests still pass.