Template part placeholders - use label and icon per variation. #31721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
added
[Feature] Full Site Editing
[Block] Template Part
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
david-szabo97,
Copons,
creativecoder and
jameskoster
|
Size Change: +470 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Nice. When I search for a "Header" I only see the regular Template Part block:
Is that because an existing template part has already been assigned to the Not sure if this is relevant enough to solve here or work on separately, but it would be nice to use the corresponding icon / label in the parent selector and list view too:
|
|
@jameskoster - that is interesting! It looks like the variations aren't registered on your end. I wonder why this is? 🤔 On my end, "Header" is still in the inserter, and the icons for parent selector and list view are the expected ones as well. |
|
I tried switching themes and deleting all my customised template parts, no change 🤔 |
|
Interesting. Im trying to investigate but having problems reproducing the issue. |
|
@jameskoster you should be able test this using |
|
Ah nice! I suspect these variations will change a bit as we work on #31750, but I can confirm that this is working and feels like an improvement over what we have. |
100% - an easy upgrade for the time being 😁 |
|
Would it be easy to change the copy as well?
And on the button:
|
Copons
reviewed
May 13, 2021
packages/block-library/src/template-part/edit/placeholder/index.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/template-part/edit/placeholder/index.js
Outdated
Show resolved
Hide resolved
Yup, updated. 😁 |
Copons
reviewed
May 13, 2021
packages/block-library/src/template-part/edit/placeholder/index.js
Outdated
Show resolved
Hide resolved
Copons
reviewed
May 13, 2021
packages/block-library/src/template-part/edit/placeholder/index.js
Outdated
Show resolved
Hide resolved
|
I updated the copy ever so slightly so that the order of objects in the sentence match the order of the buttons:
|
Copons
approved these changes
May 14, 2021
Thanks! That actually looks much better. I didn't notice the old "from the list" seems so out of context, I think that copy may have been from back before we had the list hidden under a 'choose existing' button. |
|
Curious, do we need to worry about casing here? (noticed this as i have to update e2e tests failing) Previously we were casing it as "New template part" now we are "New Template Part". I do prefer the title casing, especially considering it as a block's name, but I see it was all sentence case previously. (Similar Q with the untouched "Choose existing". |
…' of https://github.com/WordPress/gutenberg into try/template-part-placeholder-contextual-icon-and-label
david-szabo97
approved these changes
May 14, 2021
|
Since the copy refers to block variations generally, I suppose we shouldn't use title casing. |
|
Ok, updated the casing:
|
7 tasks
Addison-Stavlo
deleted the
try/template-part-placeholder-contextual-icon-and-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the template part placeholder to have title and icon corresponding to their variation. Before this, inserting a "Header" or "Footer" looks like the same placeholder as inserting a general "Template Part". Here, the title and icon are updated to reflect the variation that was selected from the inserter:
How has this been tested?
Insert Header, Footer, and Template Part blocks. Verify that their placeholders resemble what was selected as in the screenshot above.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).