New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase external media link input width, and increase top value of globe icon #32667
Increase external media link input width, and increase top value of globe icon #32667
Conversation
…lue of globe icon" This reverts commit 49ccd60.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tjcafferkey! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Failing E2E tests appear unrelated? Is there any way I can restart these? |
cc @getdave |
Yep. Click on failing test details link. Then click restart tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into fix this. Being able to see the full URL when in "edit" mode is very important.
Unfortunately whilst this works well on larger screens, on smaller viewports there appears to be a severe bug whereby the modal visually "vibrates".
Screen.Capture.on.2021-07-30.at.09-34-15.mp4
This appears to be due to some circular logic in the JS which causes a style
attribute to be repeatedly set/unset.
If we can find a way to resolve that then we'll be in a good place. I think maybe it's the min-width
you've set on the .block-editor-link-control__search-input
which you'll need to apply (using a progressive enhancement approach) only on larger viewports.
.block-editor-link-control__search-item-icon { | ||
top: 1em; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjcafferkey Anything I can do to help this along? |
Sorry @getdave I have been AFK for a few weeks. I will be picking this back up. Thanks for checking in though. |
@tjcafferkey How's this PR coming along? Can I help at all? |
Fixes #32249
Description
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).