Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase external media link input width, and increase top value of globe icon #32667

Closed

Conversation

tjcafferkey
Copy link
Contributor

@tjcafferkey tjcafferkey commented Jun 14, 2021

Fixes #32249

Description

  • Increase the width of the external media input element
  • Increase top value of globe icon

How has this been tested?

  • Create a new post or edit an existing post
  • Add "Image" block and select "Insert from URL" option
  • Enter an image URL
  • Now select the "Replace" button. Observe the correct alignment of the globe icon.
  • Click "Edit" to edit the URL. Box should expand to make the input more usable.

Screenshots

Before After

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tjcafferkey! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 14, 2021
@tjcafferkey
Copy link
Contributor Author

Failing E2E tests appear unrelated? Is there any way I can restart these?

@tjcafferkey
Copy link
Contributor Author

Failing E2E tests appear unrelated? Is there any way I can restart these?

cc @getdave

@getdave
Copy link
Contributor

getdave commented Jul 23, 2021

Yep. Click on failing test details link. Then click restart tests.

@getdave getdave self-requested a review July 28, 2021 08:20
@getdave getdave added [Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) and removed [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jul 30, 2021
@getdave getdave removed the request for review from ellatrix July 30, 2021 08:25
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into fix this. Being able to see the full URL when in "edit" mode is very important.

Unfortunately whilst this works well on larger screens, on smaller viewports there appears to be a severe bug whereby the modal visually "vibrates".

Screen.Capture.on.2021-07-30.at.09-34-15.mp4

This appears to be due to some circular logic in the JS which causes a style attribute to be repeatedly set/unset.

Screen Capture on 2021-07-30 at 09-37-47

If we can find a way to resolve that then we'll be in a good place. I think maybe it's the min-width you've set on the .block-editor-link-control__search-input which you'll need to apply (using a progressive enhancement approach) only on larger viewports.

Comment on lines +47 to +49
.block-editor-link-control__search-item-icon {
top: 1em;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-07-30 at 09 28 06

Not sure this is necessary any longer as I was unable to replicate. I merged a PR recently which sorted out all this globe icon alignment so hopefully that's done it.

@getdave
Copy link
Contributor

getdave commented Aug 13, 2021

@tjcafferkey Anything I can do to help this along?

@tjcafferkey
Copy link
Contributor Author

Sorry @getdave I have been AFK for a few weeks. I will be picking this back up. Thanks for checking in though.

@getdave
Copy link
Contributor

getdave commented Oct 4, 2021

@tjcafferkey How's this PR coming along? Can I help at all?

@cbravobernal cbravobernal self-requested a review June 2, 2022 10:45
@cbravobernal cbravobernal removed their request for review June 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image block: Replace Current media URL field too small
2 participants