Adjust legacy widget form styles to match editor. #32974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Feature] Widgets Screen
tellthemachines
added this to PRs needing review
in Block-based Widgets Editor
via automation
|
Size Change: -47 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Jun 25, 2021
talldan
added
the
Backport to WP Beta/RC
|
The test I think #32889 is fixing the issue with that test anyway. |
youknowriad
removed
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
|
I am still seeing issues with number and select fields.
It is a good step forward but doesn't fix the original issue #32955 . This is a simple css fix, any chance of getting this in? CC @tellthemachines |
|
@spacedmonkey your screenshot shows the styles previous to this PR are still applying. Can you rebuild your env with the latest changes and recheck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32955 by adding styles for legacy widget form fields that match the editor defaults (as much as possible given we don't control the markup of third party widget forms.)
How has this been tested?
Activate Twenty Twenty theme, install Web Stories plugin.
In Widgets editor, add Web Stories legacy widget and check that form fields look reasonably consistent with editor styles.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).