Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Data: getEntityRecords return items even if some included IDs don't exist #34034

Merged
merged 2 commits into from Aug 12, 2021
Merged

Core Data: getEntityRecords return items even if some included IDs don't exist #34034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2f9722
Core Data: getEntityRecords return items even if some included IDs do…
Mamaduka Aug 12, 2021
646be8a
Always use the response as a source of truth for itemIds
Mamaduka Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/core-data/src/queried-data/selectors.js
View file
Open in desktop
Expand Up @@ -38,15 +38,7 @@ function getQueriedItemsUncached( state, query ) {
} = getQueryParts( query );
let itemIds;

if ( Array.isArray( include ) && ! stableKey ) {
// If the parsed query yields a set of IDs, but otherwise no filtering,
// it's safe to consider targeted item IDs as the include set. This
// doesn't guarantee that those objects have been queried, which is
// accounted for below in the loop `null` return.
itemIds = include;
// TODO: Avoid storing the empty stable string in reducer, since it
// can be computed dynamically here always.
} else if ( state.queries?.[ context ]?.[ stableKey ] ) {
if ( state.queries?.[ context ]?.[ stableKey ] ) {
itemIds = state.queries[ context ][ stableKey ];
}

Expand All @@ -67,6 +59,7 @@ function getQueriedItemsUncached( state, query ) {
continue;
}

// Having a target item ID doesn't guarantee that this object has been queried.
if ( ! state.items[ context ]?.hasOwnProperty( itemId ) ) {
return null;
}
Expand Down