[Components]: Rename SegmentedControl to ToggleGroupControl #34111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
ntsekouras
requested review from
youknowriad,
ciampo,
diegohaz and
sarayourfriend
|
Size Change: -43 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
I think this renaming makes sense.
@mtias mentioned his doubts about the Control suffix. While it's a legitimate thing, I wonder if we should stick to it for consistency reasons with components we can't rename.
After checking the other component names here: https://developer.wordpress.org/block-editor/reference-guides/components/, I thought it was better to keep the suffix for consistency, so I agree with Riad. I have no strong opinions though, and can be changed if needed.. |
|
If we'd like to be moving to a different place regarding naming I don't think current consistency should be the deciding factor. It'd be best to avoid a subsequent rename. Curious what @diegohaz thinks as it's an important part of making the component set approachable. |
|
Regarding the Regarding I see 2 patterns with which this component design could be implemented: radio group or tab list. We're currently using the radio group here, which makes more sense for the use cases we have. But I can see how this component design could be used to control the visibility of sections, in which case the tab list would make more sense. But I don't think the toggle button pattern applies here. For example, in the image below we have a group of toggle buttons (format) and a radio group (alignment).
Screenshot from https://www.w3.org/TR/wai-aria-practices-1.2/examples/toolbar/toolbar.html The main difference is that the toggle button group may have more than one selected (technically, The markup is also quite different: <!-- toggle button group (simplified) -->
<div>
<button type="button" aria-pressed="true"></button>
<button type="button" aria-pressed="true"></button>
<button type="button" aria-pressed="false"></button>
</div>
<!-- radio group (simplified) -->
<div role="radiogroup">
<div role="radio" aria-checked="false" tabindex="-1"></div>
<div role="radio" aria-checked="true" tabindex="0"></div>
<div role="radio" aria-checked="false" tabindex="-1"></div>
</div>On the other hand, I guess "toggle group" doesn't necessarily mean "a group of toggle buttons", and I can find a lot of examples on the internet where "toggle group" is just another name for "radio group". I also understand that, since we're not only dealing with semantics, but also with layout, So, I'm not opposed to |
ntsekouras
deleted the
rename/segmented-control-to-toggle-group-control
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of: #34017 (comment)
In this PR
SegmentedControlis renamed toToggleGroupControl. The internalRadioGroupused is fromReakitso it needs more investigation if it can be removed with the currentRadioGroupfromwordpress/components- this is subject to change name as well toToggleGroupand not be exposed in a follow up PR probably..Testing instructions
PostFeaturedImagewhen aheightvalue is set. So this should work as expected