Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow: only commit modified changelogs #34211

Merged
merged 1 commit into from Aug 25, 2021

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Aug 20, 2021

Description

Checks if changelog.txt committed in the context of this workflow is different from the one in trunk and in the release branch. This makes it possible to re-run the workflow in order to re-try the upload of the plugin archive to the directory. Before, since attempting to create a commit without changes exits with an error, the upload step was being skipped (eg. this retried run)

This would've allowed us to use the workflow in order to fix the failure we faced when releasing Gutenberg v11.3.0, where the SVN upload timed out; @youknowriad saved the day committing the plugin manually.

How has this been tested?

Tried these changes in a fork (SVN Upload fails there because I purposefully did not configure secrets.)

  1. First run updates the changelog correctly.
  2. Subsequent re-runs don't attempt to commit unchanged files.
  3. Upload step runs again every time.

@vcanales vcanales added [Type] Enhancement A suggestion for improvement. [Type] Build Tooling Issues or PRs related to build tooling labels Aug 20, 2021
@vcanales vcanales added this to the Gutenberg 11.4 milestone Aug 20, 2021
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement. Should we do the same for the SVN commit and tagging as well?

@vcanales
Copy link
Member Author

Should we do the same for the SVN commit and tagging as well?

I'm not proficient enough in svn to tell for sure, but in testing trying to create a commit with no changed files did not result in an error, so the workflow would not fail in this case.

@youknowriad youknowriad merged commit 8a88997 into trunk Aug 25, 2021
@youknowriad youknowriad deleted the try/skip-changelog-update-on-retry branch August 25, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants