Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Delete the createComponent utility function #34929

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Components: Delete the createComponent utility function #34929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bec77
Delete the `createComponent` function
ciampo Aug 27, 2021
4660e50
Changelog
ciampo Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

### Internal

- Renamed `PolymorphicComponent*` types to `WordPressComponent*` ([#34330](https://github.com/WordPress/gutenberg/pull/34330))
- Renamed `PolymorphicComponent*` types to `WordPressComponent*` ([#34330](https://github.com/WordPress/gutenberg/pull/34330)).
- Deleted the `createComponent` utility function ([#34929](https://github.com/WordPress/gutenberg/pull/34929)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under Unreleased, no? I don't suppose it's going to trip anyone up though. I happened to notice this when I went to make a changelog edit in #35020 and we could update it in that PR if you'd like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct — I missed that Unreleased header. Well spotted!

I went to make a changelog edit in #35020 and we could update it in that PR if you'd like

That would be great, thank you


## 16.0.0 (2021-08-23)

Expand Down
58 changes: 0 additions & 58 deletions packages/components/src/ui/utils/create-component.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/components/src/ui/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export { getOptimalTextShade } from './colors';
export { createComponent } from './create-component';
70 changes: 0 additions & 70 deletions packages/components/src/ui/utils/test/create-component.js
View file
Open in desktop

This file was deleted.