New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Use Lodash's find in place of Array#find #3502

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Nov 15, 2017

Regression introduced in: #3281
Related: #746

This pull request seeks to resolve errors which occur in IE11 when attempting to use the inserter. The root cause is using array prototype methods which are neither supported nor polyfilled in IE11 (specifically, Array#find). The changes here propose to use the Lodash _.find equivalent, also leveraging object shorthand predicates.

Testing instructions:

Repeat testing instructions from #3281

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 15, 2017

Codecov Report

Merging #3502 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3502   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files         260      260           
  Lines        6757     6757           
  Branches     1226     1226           
=======================================
  Hits         2339     2339           
  Misses       3728     3728           
  Partials      690      690
Impacted Files Coverage Δ
editor/components/inserter/group.js 55% <0%> (ø) ⬆️
components/tab-panel/index.js 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5255c93...cefa3aa. Read the comment docs.

codecov bot commented Nov 15, 2017

Codecov Report

Merging #3502 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3502   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files         260      260           
  Lines        6757     6757           
  Branches     1226     1226           
=======================================
  Hits         2339     2339           
  Misses       3728     3728           
  Partials      690      690
Impacted Files Coverage Δ
editor/components/inserter/group.js 55% <0%> (ø) ⬆️
components/tab-panel/index.js 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5255c93...cefa3aa. Read the comment docs.

@aduth aduth merged commit b6bfb70 into master Nov 15, 2017

3 checks passed

codecov/project 34.61% (+0%) compared to 5255c93
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the remove/array-find branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment