Gallery block: fix problem with caption showing encode tags when not selected #35131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gure when not focused
glendaviesnz
added
the
[Block] Gallery
|
Size Change: -66 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Nice work @glendaviesnz, this is testing well for me:
✅ With a user without the unfiltered_html capability, I could recreate the issue, and with this PR applied, toggling between the gallery caption and the rest of the post preserves the formatting without rendering the encoded tags
✅ Saved post content is unaffected, and the experience feels the same with an admin user
✅ The caption formatting toolbar disappears when I select the media placeholder, de-select the gallery, or select a gallery image
✅ The change also fixes an extra click that seemed to be required for the user without the unfiltered_html capability (which also nudged the viewport position), so clicking between another block and the gallery caption feels smoother now, too 👍
| Before | After |
|---|---|
 |
 |
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If logged in as a user without unsafe html privileges the Gallery caption in the refactored Gallery block shows encoded html tags when the caption is not selected. This PR removes the toggle between
RichTextandfigureand keeps it asRichTextFixes: #34829
Testing
AuthorScreenshots
Before:
After:
