Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] [Embed block] Detect when an embeddable URL is pasted into an empty paragraph #35204

Merged
merged 33 commits into from Oct 13, 2021
Merged

[RNMobile] [Embed block] Detect when an embeddable URL is pasted into an empty paragraph #35204

merged 33 commits into from Oct 13, 2021

Commits on Sep 29, 2021

  1. added unstableEmbedURLOnPaste prop to activate embed detection.

    @jd-alexander
    jd-alexander committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    8e7ae99 View commit details
    Browse the repository at this point in the history

  2. reintegrated Embed transformation that was disabled - testing required.

    @jd-alexander
    jd-alexander committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    3df07fa View commit details
    Browse the repository at this point in the history

  3. Added functionality that would convert the URL to a link.

    @jd-alexander
    jd-alexander committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    1010372 View commit details
    Browse the repository at this point in the history

  4. integrated the bottom sheet component that displays Create embed/link.

    @jd-alexander
    jd-alexander committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4130c4b View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. The EmbedHandlerPicker was extracted to a standalone component.

    @jd-alexander
    jd-alexander committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    1739f62 View commit details
    Browse the repository at this point in the history

  2. Updated changelog.

    @jd-alexander
    jd-alexander committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    e8854be View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Merge branch 'trunk' into rnmobile/embed-block-paste-url

    @jd-alexander
    jd-alexander committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    7390971 View commit details
    Browse the repository at this point in the history

  2. added onChange to the embed logic so that the url is visible.

    @jd-alexander
    jd-alexander committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    1b41af9 View commit details
    Browse the repository at this point in the history

  3. only process URLs on empty paragraphs.

    @jd-alexander
    jd-alexander committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    8f38899 View commit details
    Browse the repository at this point in the history

  4. utilized useCallback to lessen re-renders.

    @jd-alexander
    jd-alexander committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    be43155 View commit details
    Browse the repository at this point in the history

  5. added pickerOptions to the dependencies array.

    @jd-alexander
    jd-alexander committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    579def2 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. if there is content within a paragraph then insert the link.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    eaec369 View commit details
    Browse the repository at this point in the history

  2. utilized isEmpty to check the text property of value.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    00a4f9d View commit details
    Browse the repository at this point in the history

  3. memoized the EmbedHandlerPicker

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    74da669 View commit details
    Browse the repository at this point in the history

  4. Added a comment to clarify changes.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    7975a76 View commit details
    Browse the repository at this point in the history

  5. Fixed issue with release notes that doesn't follow format.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0334b75 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into rnmobile/embed-block-paste-url

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    b961e49 View commit details
    Browse the repository at this point in the history

  7. refactored embed paste logic.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    6cd4591 View commit details
    Browse the repository at this point in the history

  8. disables onReplace on non embed rich-text instances.

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    9d3a548 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'trunk' into rnmobile/embed-block-paste-url

    @jd-alexander
    jd-alexander committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    f59cff0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Fixed CHANGELOG formatting issue.

    @jd-alexander
    jd-alexander committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    b508ae8 View commit details
    Browse the repository at this point in the history

  2. Fixed formatting issue in CHANGELOG.

    @jd-alexander
    jd-alexander committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    9e14dd3 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. refactored the Embed pasting logic so that it is centralized

    @jd-alexander
    jd-alexander committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    6752e72 View commit details
    Browse the repository at this point in the history

  2. Changed the variable to something more meaningful.

    @jd-alexander
    jd-alexander committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e0ce9a3 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary content length check since this is already checked.

    @jd-alexander
    jd-alexander committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    cf9d168 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into rnmobile/embed-block-paste-url

    @jd-alexander
    jd-alexander committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9b8a322 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. if block is not derived then we check if content is a string url.

    @jd-alexander
    jd-alexander committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7d22100 View commit details
    Browse the repository at this point in the history

  2. Refactor embed paste logic

    @fluiddot
    fluiddot committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    1683920 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'rnmobile/embed-block-paste-url' of github.com:WordPress… 

    …/gutenberg into rnmobile/embed-block-paste-url

# Conflicts:
#	packages/block-editor/src/components/rich-text/index.native.js
    @fluiddot
    fluiddot committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    b5174f3 View commit details
    Browse the repository at this point in the history

  4. Removed the __unstableEmbedURLOnPaste flag from mode logic for Heading

    @jd-alexander
    jd-alexander committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    f3f4603 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Resolved isPastedURL logic issues to fix HEADING bug.

    @jd-alexander
    jd-alexander committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5eadfc9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/embed-block-paste-url

    @jd-alexander
    jd-alexander committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a6e9141 View commit details
    Browse the repository at this point in the history

  3. Fixed typo in CHANGELOG.

    @jd-alexander
    jd-alexander committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5a15e99 View commit details
    Browse the repository at this point in the history