Remove top link from embedded content block fix #3497 #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested changes
Nov 20, 2017
There was a problem hiding this comment.
Investigating how this is handled on the front-end, it appears we should be injecting a script into the frames which manages the hiding of original content, "wp-embed.js":
Generally speaking, the Sandbox component is meant to be reusable and should ideally not include styles specific to e.g. embed behavior.
3 tasks
|
Closing in favour of the active PR #4226. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to close #3497 by hidding
blockquotefrom the embedded iframe.How Has This Been Tested?
Add some embedded blocks, verify the top link does not appear.
Screenshots (jpeg or gifs if applicable):