Fix ToggleGroupControlOption not passing ref to the underlying element

[diegohaz]

This PR is a small fix to avoid future issues.

The internal ToggleGroupControlButton component doesn't accept a ref prop. Instead, it expects to receive forwardedRef:

gutenberg/packages/components/src/toggle-group-control/toggle-group-control-button.tsx

Line 23 in 17bb52b

forwardedRef,

Because of this, passing ref to ToggleGroupControlOption wouldn't work.

[ntsekouras]

Thanks for the fix!

[ciampo]

Out of curiosity, would using React.forwardRef be a cleaner solution instead of having a prop called forwardedRef?

[diegohaz]

Since this component is not exposed, I'm okay with the forwardedRef prop. But we can refactor it so all the logic is inside ToggleGroupControlOption. And then delete ToggleGroupControlButton to simplify the code.

[ciampo]

Since this component is not exposed, I'm okay with the forwardedRef prop. But we can refactor it so all the logic is inside ToggleGroupControlOption. And then delete ToggleGroupControlButton to simplify the code.

Makes sense.

We should merge this PR to get the fix in the codebase and then open a follow-up PR to merge ToggleGroupControlButton into ToggleGroupControlOption (let me know if you'd prefer to work on it directly, otherwise I can work on it myself).

[ciampo]

We should merge this PR to get the fix in the codebase and then open a follow-up PR to merge ToggleGroupControlButton into ToggleGroupControlOption

I will take care of this and open a PR soon

Update: Opened #35600