[Automated Testing]: Fix preview e2e tests #35565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Automated Testing
|
Size Change: +271 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 12, 2021
Locally tests were passing for me as well 😄 |
Mamaduka
reviewed
Oct 12, 2021
At this point, it's expected from e2e tests 😄 |
ellatrix
reviewed
Oct 13, 2021
| // A success notice should show up | ||
| return page.waitForSelector( '.components-snackbar' ); | ||
| // `PostPublishPanelPostpublish` will be visible after the post is published. | ||
| return page.waitForSelector( '.post-publish-panel__postpublish' ); |
There was a problem hiding this comment.
Looks like this is not there in some cases. What if we dismiss the previous snackbar before checking again?
There was a problem hiding this comment.
Seems the alternative PR didn't seem to do the trick either.. How do you feel about adding a temp fix for this test for now to make CI green and handle the main problem separately?
7 tasks
ellatrix
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35387
Previously
publishPostutil relied on waiting for the snackbar to exist, but after #34731 a snackbar is shown in other cases as well - like saving a draft. This can create unexpected results with race conditions. An example would be the preview test here where:publishPostresolved sooner than what we wantedgetEditedEntityRecordgets these edits.I think I got it right here with the flow.. --cc @youknowriad ?
This PR changes the util to wait for
PostPublishPanelPostpublish.--edit seems PostPublishPanelPostpublish is not doing the trick and should find a better way to reliably know when a post is published..