Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacer: add custom units for height and width #36186

Merged
merged 16 commits into from
Dec 23, 2021
Merged

Spacer: add custom units for height and width #36186

merged 16 commits into from
Dec 23, 2021

Commits on Dec 22, 2021

  1. Add width and height units and use the custom UnitControl

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    c96ea20 View commit details
    Browse the repository at this point in the history

  2. Refactor out the ResizableSpacer and fix resizing in the canvas

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e72c59a View commit details
    Browse the repository at this point in the history

  3. Correctly initialize width and height for horizontal spacer

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    54fe4e9 View commit details
    Browse the repository at this point in the history

  4. Handle min and max values for px

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    b92f515 View commit details
    Browse the repository at this point in the history

  5. Apply unit to the dimensions on the frontend

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    148a0a8 View commit details
    Browse the repository at this point in the history

  6. Refactor out the controls

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5d339d5 View commit details
    Browse the repository at this point in the history

  7. Disable percentage units for Spacer

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    42eb0c3 View commit details
    Browse the repository at this point in the history

  8. Only output width or height styles as needed for orientation

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    0bc2088 View commit details
    Browse the repository at this point in the history

  9. Correctly generate styles when width or height is set to 0

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    357c38c View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary parsing, interpolation

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    9a4ceef View commit details
    Browse the repository at this point in the history

  11. Remove separate unit attributes and update type of height and width a… 

    …ttrs
    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    b74affc View commit details
    Browse the repository at this point in the history

  12. Add block deprecation

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    af3945d View commit details
    Browse the repository at this point in the history

  13. Update and add fixtures for deprecation

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    4b956dc View commit details
    Browse the repository at this point in the history

  14. Update snapshots

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8ff769c View commit details
    Browse the repository at this point in the history

  15. Ensure that the unit is updated to px when resizing by dragging the h… 

    …andle
    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    3574dec View commit details
    Browse the repository at this point in the history

  16. Add mobile support for custom units

    @stacimc @aaronrobertshaw
    stacimc authored and aaronrobertshaw committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    bec0c5e View commit details
    Browse the repository at this point in the history