Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace get_theme_file_path() with self:get_file_path_from_theme(). #36359

Closed
wants to merge 1 commit into from

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Nov 9, 2021

Description

This copies the fix in Core-52077 from WordPress trunk to the plugin.

After Core-52049, style assets in the admin were not loading due to a fatal error when SCRIPT_DEBUG was set to false.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@desrosj desrosj self-assigned this Nov 9, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Nov 9, 2021

Hi, @desrosj

Sorry, I just saw the recent comments on the track ticket. This change will break child themes.

The method should return true if the parent or child has a theme.json file. It is required to load "Global Styles" correctly.

It think we should duplicate get_theme_file_path logic in :: theme_has_support.

@desrosj
Copy link
Contributor Author

desrosj commented Nov 15, 2021

Closing in favor of #36398.

@desrosj desrosj closed this Nov 15, 2021
@desrosj desrosj deleted the core/54401 branch November 15, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants