Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add tests for DefaultBlockAppender #3638

Merged
merged 1 commit into from Nov 24, 2017

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 24, 2017

Description

Follow-up for #3623.

As discussed in the referenced PR, I'm adding tests for newly introduced DefaultBlockAppender component.

How Has This Been Tested?

npm run test-unit

Types of changes

Adds tests.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Nov 24, 2017
@gziolo gziolo self-assigned this Nov 24, 2017
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Thanks

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3638 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3638     +/-   ##
========================================
+ Coverage   36.69%   36.8%   +0.1%     
========================================
  Files         268     268             
  Lines        6649    6649             
  Branches     1201    1201             
========================================
+ Hits         2440    2447      +7     
+ Misses       3557    3550      -7     
  Partials      652     652
Impacted Files Coverage Δ
editor/components/default-block-appender/index.js 87.5% <ø> (+87.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f9b1a...89a571c. Read the comment docs.

@gziolo gziolo merged commit 7b19f4f into master Nov 24, 2017
@gziolo gziolo deleted the add/tests-default-block-appender branch November 24, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants