New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add tests for DefaultBlockAppender #3638

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Nov 24, 2017

Description

Follow-up for #3623.

As discussed in the referenced PR, I'm adding tests for newly introduced DefaultBlockAppender component.

How Has This Been Tested?

npm run test-unit

Types of changes

Adds tests.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo self-assigned this Nov 24, 2017

@gziolo gziolo requested a review from youknowriad Nov 24, 2017

@youknowriad

Awesome Thanks

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 24, 2017

Codecov Report

Merging #3638 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3638     +/-   ##
========================================
+ Coverage   36.69%   36.8%   +0.1%     
========================================
  Files         268     268             
  Lines        6649    6649             
  Branches     1201    1201             
========================================
+ Hits         2440    2447      +7     
+ Misses       3557    3550      -7     
  Partials      652     652
Impacted Files Coverage Δ
editor/components/default-block-appender/index.js 87.5% <ø> (+87.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f9b1a...89a571c. Read the comment docs.

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3638 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3638     +/-   ##
========================================
+ Coverage   36.69%   36.8%   +0.1%     
========================================
  Files         268     268             
  Lines        6649    6649             
  Branches     1201    1201             
========================================
+ Hits         2440    2447      +7     
+ Misses       3557    3550      -7     
  Partials      652     652
Impacted Files Coverage Δ
editor/components/default-block-appender/index.js 87.5% <ø> (+87.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f9b1a...89a571c. Read the comment docs.

@gziolo gziolo merged commit 7b19f4f into master Nov 24, 2017

3 checks passed

codecov/project 36.8% (+0.1%) compared to 42f9b1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gziolo gziolo deleted the add/tests-default-block-appender branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment