Components: Extract Reusable Keyboard Shortcuts

[youknowriad]

Extract a reusable Keyboard Shortcuts component to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

Testing instructions

• Try muti-selecting blocks using ctrl+A

[codecov]

Codecov Report

Merging #3644 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3644      +/-   ##
==========================================
- Coverage    36.9%   36.74%   -0.17%     
==========================================
  Files         271      274       +3     
  Lines        6630     6659      +29     
  Branches     1201     1205       +4     
==========================================
  Hits         2447     2447              
- Misses       3531     3556      +25     
- Partials      652      656       +4

Impacted Files	Coverage Δ
...mponents/editor-global-keyboard-shortcuts/index.js	0% <0%> (ø)
editor/edit-post/modes/visual-editor/index.js	0% <0%> (ø)	⬆️
editor/edit-post/header/index.js	0% <0%> (ø)	⬆️
editor/edit-post/header/publish-dropdown/index.js	0% <0%> (ø)
...or/edit-post/header/publish-with-dropdown/index.js	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1856f8c...487d5d4. Read the comment docs.

[mcsf]

@youknowriad, two questions:

1. Shouldn't EditorGlobalKeyboardShortcuts be VisualModeKeyboardShortcuts instead? We now also have EditorModeKeyboardShortcuts (Try: Add toggle editor mode shortcut #3755), which is actually global and should also be renamed to express that.

2. Shoud EditorGlobalKeyboardShortcuts be in @wordpress/components? It feels pretty tied to the editor, and the basic piece KeyboardShortcuts is already available in @wordpress/components anyway.

I'm looking at this in the context of #4323, and thinking ahead that that feature should be built as an extension. The two *KeyboardShortcuts components—the global and the visual-mode-only—should be hookable, perhaps via a .extraProps or .extraShortcuts filter.

[youknowriad]

Shouldn't EditorGlobalKeyboardShortcuts be VisualModeKeyboardShortcuts instead? We now also have EditorModeKeyboardShortcuts (#3755), which is actually global and should also be renamed to express that.

Make sense

Shoud EditorGlobalKeyboardShortcuts be in @wordpress/components? It feels pretty tied to the editor, and the basic piece KeyboardShortcuts is already available in @wordpress/components anyway.

I don't think so since @wordpress/components is not editor specific while EditorGlobalKeyboardShortcuts is (in countrary to KeyboardShortcuts).

[mcsf]

I don't think so since @wordpress/components is not editor specific while EditorGlobalKeyboardShortcuts is (in countrary to KeyboardShortcuts).

Yep, we're on the same page, I was surprised to see it in components.

[youknowriad]

It's not in components, it's in editor/components

There's also one important difference between EditorGlobalKeyboardShortcuts and EditorModeKeyboardShortcuts which is. The later is EditorGlobalKeyboardShortcuts are generic keyboard shortcuts (could be reused to build alternative layouts like P2 editor) while EditorModeKeyboardShortcuts is specific to the layout of the Post Editor edit-post directory.

[mcsf]

It's not in components, it's in editor/components

Oh, yes, I misread from my :grep. 🙈

while EditorModeKeyboardShortcuts is specific to the layout of the Post Editor edit-post directory.

👍