[RNMobile][iOS] Fix scroll update when typing in RichText component #36914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
Merged
2 tasks
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
SiobhyB
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
I tested on iOS and confirm that the scrolling issue is resolved with this change applied. I also double-checked on Android, just in case, and spotted no regressions there.
Thanks for requesting me as a reviewer! It was interesting to learn a little more about how Aztec works with Gutenberg through the linked comments here. Approved. 
|
(Aside: one of the End-to-End tests failed, but it looked to be flakiness rather than an issue with the PR, so I re-ran it.) |
Thank you @SiobhyB for the review 🙇 ! It was also interesting for me to learn more about Aztec, and it's always funny when a bug is fixed by a single line of code, it took me more time to run the investigations than coding 😅 . |
fluiddot
commented
Nov 26, 2021
Comment on lines
-26
to
+34
| - [**] Fixed a crash that could occur when copying lists from Microsoft Word. [https://github.com/WordPress/gutenberg/pull/36019] | ||
| - [**] Fixed a crash that could occur when copying lists from Microsoft Word. [https://github.com/WordPress/gutenberg/pull/36019] | ||
|
|
||
| ## 1.65.0 | ||
| - [**] Search block - Text and background color support [#35511] | ||
| - [*] [Embed Block] Fix loading glitch with resolver resolution approach [#35798] | ||
| * [*] Fixed an issue where the Help screens may not respect an iOS device's notch. [#35570] | ||
| - [**] Block inserter indicates newly available block types [#35201] | ||
| - [*] Add support for the Mark HTML tag [#35956] | ||
| - [**] Search block - Text and background color support [#35511] | ||
| - [*] [Embed Block] Fix loading glitch with resolver resolution approach [#35798] | ||
| - [*] Fixed an issue where the Help screens may not respect an iOS device's notch. [#35570] | ||
| - [**] Block inserter indicates newly available block types [#35201] | ||
| - [*] Add support for the Mark HTML tag [#35956] |
There was a problem hiding this comment.
I noticed that these entries had a different format so I reformatted them.
|
@SiobhyB Heads up that I've pushed a couple of commits to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4299
Description
This PR updates how the target ID parameter is obtained from the native event (reference), which is used when notifying the
KeyboardAwareFlatListcomponent that the caret vertical position has changed on iOS (reference).The type of the value previously obtained was
ReactNativeFiberHostComponent, however, the expected value is a number (reference). I noticed that the target ID is actually passed within thenativeEventproperty of the event object, so now we'll pass that property instead.gutenberg/packages/components/src/mobile/keyboard-aware-flat-list/index.ios.js
Line 78 in 96a0daf
NOTE: More info about the issue can be found in comment: wordpress-mobile/gutenberg-mobile#4069 (comment)
How has this been tested?
NOTE: The fix only applies to iOS, as on Android it couldn't be reproduced (reference).
Screenshots
scroll-on-caret-vertical-update.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).