E2E Tests: Verify that we can publish even if some changes haven't been saved #37408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2021
Merged
|
Current test output (snippet): Note that the This, along some possible strategies to make it fail the test, is discussed over at #36096 (comment) |
|
Size Change: +2.17 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Wondering if the issue could be due to something like jestjs/jest#11054 (essentially console output buffering). IIUC, the fix was released as part of Jest 27.2.x, and we have yet to upgrade to Jest 27. Might be worth trying this PR on top of the Jest upgrade PR. |
Tried that -- that's also not it. |
|
@gziolo had a few suggestions over in #36096 (React error boundaries, What I don't really get is where this (i.e. I'll probably punt this for now, I've wasted too much time on it already. If anyone has an idea on how to get this to fail, feel free to pick it up. (Note that I've purposefully not rebased this PR yet on #37383, since we need to make sure the test really fails without that fix.) |
|
Giving this one more try 😅 It seems like I can catch the error using It seems like |
|
With 2a64a02 (and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #36096 (comment). Provides test coverage for the issue described at #36096 (comment), which has a fix at #37383.
Note that this is still a WIP: The test is currently not failing, even though the tested functionality is.
For background, see discussion starting at #36096 (comment).
How has this been tested?
Types of changes
Code quality